Fix handle not unique issue on page layout copy #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrinDY
added
bug
Fajfa
requested changes
May 26, 2023
| @@ -779,7 +779,7 @@ export default { | |||
|
|
|||
| layout.meta.title = `${layout.meta.title}` | |||
|
|
|||
| this.createPageLayout(this.layout).then(({ layoutID }) => { | |||
| this.createPageLayout(layout).then(({ layoutID }) => { | |||
There was a problem hiding this comment.
Why this layout? The layout is created three lines above, and that one should be used
There was a problem hiding this comment.
This is a case of me being blind, all good
Fajfa
approved these changes
May 29, 2023
Fajfa
force-pushed
the
2023.3.x-bugfix-layout-copy-issue
branch
from
97b3a55
to
98c8f92
Compare
Fajfa
force-pushed
the
2023.3.x-bugfix-layout-copy-issue
branch
from
98c8f92
to
a91f5de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are implemented
Layout issue was fixed
Changes in the user interface:
None
Checklist when submitting a final (!draft) PR