Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.3.x feature custom css #1262

Merged
merged 1 commit into from Jun 27, 2023
Merged

Conversation

KinyaElGrande
Copy link
Contributor

@KinyaElGrande KinyaElGrande commented Jun 15, 2023

Ref: #1224

This PR aims to enhance webapps customization by introducing CSS customization feature at runtime. This feature allows the admin to dynamically customize the CSS styles of the webapps.

To customize CSS for a specific webapp, admins can utilize the following ID selectors to target them:

  • #admin for the Admin web app
  • #compose for the Compose web app
  • #discovery for the Discovery web app
  • #one for the One web app
  • #privacy for the Privacy web app
  • #reporter for the Reporter web app
  • #workflow for the Workflow web app

Screenshots

Screenshot 2023-06-23 at 14 43 09

Screenshot 2023-06-23 at 14 42 11

@KinyaElGrande KinyaElGrande linked an issue Jun 16, 2023 that may be closed by this pull request
Copy link
Member

@tjerman tjerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; do change the WIP commit to something informative @Fajfa
Good job lads 👌

server/pkg/webapp/serve.go Outdated Show resolved Hide resolved
client/web/one/public/custom.css Outdated Show resolved Hide resolved
@KinyaElGrande KinyaElGrande force-pushed the 2023.3.x-feature-custom-css branch 2 times, most recently from c2b15eb to 599894d Compare June 23, 2023 07:31
client/web/admin/src/views/UI/Index.vue Outdated Show resolved Hide resolved
title: Custom CSS
modal:
editor: Custom CSS editor
cancel: cancel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use saveAndClose from general:label and Cancel can also be added to general:label
So you can remove these two

@KinyaElGrande KinyaElGrande force-pushed the 2023.3.x-feature-custom-css branch 2 times, most recently from 4182d8d to 4d4af44 Compare June 23, 2023 13:36
@KinyaElGrande KinyaElGrande merged commit 037c53d into 2023.3.x Jun 27, 2023
1 check passed
@KinyaElGrande KinyaElGrande deleted the 2023.3.x-feature-custom-css branch June 27, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom css at runtime
3 participants