Add inline editing to record block #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Fajfa
requested changes
Jun 30, 2023
| transition: opacity 0.25s; | ||
| } | ||
|
|
||
| .field-label:hover .inline-actions { |
There was a problem hiding this comment.
It should be displayed when you hover over the field element, not just the label part)
| @@ -224,3 +296,25 @@ export default { | |||
| min-height: 1.2rem; | |||
| } | |||
| </style> | |||
|
|
|||
| <style lang="scss" scoped> | |||
| .field-label{ | |||
There was a problem hiding this comment.
You can do inline styles in template for this (d-flex align-items-center), the gap you dont need since you have ml-1 on the inline action anyway
| } | ||
|
|
||
| .inline-actions { | ||
| width: fit-content; |
| cols="12" | ||
| md="6" | ||
| > | ||
| <b-form-group |
There was a problem hiding this comment.
This can be in the general settings section, it belongs there.
| md="6" | ||
| > | ||
| <b-form-group | ||
| :label="$t('record.inlineEdit.enabled')" |
There was a problem hiding this comment.
The translation is missing here, should be same/similar as the one in the record list
| @@ -245,6 +245,7 @@ record: | |||
| listLoadFailed: Could not load record list | |||
| moduleOrPageNotSet: 'RecordList block error: module or page option not set' | |||
| moduleMismatch: Module incompatible, module mismatch | |||
| recordLabel: Records | |||
There was a problem hiding this comment.
Since you dont need the extra section, you wont need this
Fajfa
approved these changes
Jul 3, 2023
|
todo: disable the edit btn when we're in page builder |
Fajfa
requested changes
Jul 5, 2023
Fajfa
force-pushed
the
2023.3.x-feature-add-inline-editing-record-block
branch
2 times, most recently
from
eb30bfc
to
fc6dbe8
Compare
|
Writing this down so I don't forget it:
|
|
LGTM |
kelanik8
force-pushed
the
2023.3.x-feature-add-inline-editing-record-block
branch
2 times, most recently
from
8dc5664
to
3044263
Compare
Fajfa
approved these changes
Jul 7, 2023
|
LGTM |
kelanik8
force-pushed
the
2023.3.x-feature-add-inline-editing-record-block
branch
from
dcc20be
to
0b9ccdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are implemented
TODO: Summary
Changes in the user interface:
TODO: Add screenshots, recordings or remove this section
Checklist when submitting a final (!draft) PR