Add new select types to Select field #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fajfa
requested changes
Jul 6, 2023
| <b-form-checkbox | ||
| v-if="f.options.selectType !== 'multiple'" | ||
| v-if="shouldAllowDuplicates" |
There was a problem hiding this comment.
This checkbox needs to be moved out of the form group, and same for User and Record selector
| @@ -152,10 +151,11 @@ export default { | |||
| data () { | |||
| return { | |||
| newOption: { value: undefined, text: undefined, new: true }, | |||
| selectOptions: [ | |||
| selectOptionss: [ | |||
| @@ -184,6 +184,23 @@ export default { | |||
| isNew () { | |||
| return this.module.moduleID === NoID || this.field.fieldID === NoID | |||
| }, | |||
|
|
|||
| selectOptions () { | |||
| const options = [ | |||
There was a problem hiding this comment.
Why redefine it if you have it already defined in the data.
Instead of filtering like this, which then needs to be amended if a new option is added, do a property on the option object that will indicate if its only usable if multi. And then you can filter by that always.
| }, | ||
|
|
||
| shouldAllowDuplicates () { | ||
| return this.f.options.selectType !== 'multiple' && this.f.isMulti && this.f.options.selectType !== 'list' |
There was a problem hiding this comment.
Lets make this more readable, you can add a property to the option that will indicate if it supports duplicates.
if (!this.f.isMulti) return false
const { duplicates = false } = this.options.find(({ value }) => value === this.f.options.selectType) || {}
return duplicates
| @@ -92,6 +105,14 @@ | |||
| </option> | |||
| </template> | |||
| </b-form-select> | |||
|
|
|||
| <b-form-radio-group | |||
| v-else | |||
There was a problem hiding this comment.
Do it the other way around, if its list view display that, otherwise(v-else) the default.
Fajfa
reviewed
Jul 6, 2023
| @@ -30,7 +30,16 @@ | |||
| </template> | |||
|
|
|||
| <template v-if="field.isMulti"> | |||
| <template v-if="field.options.selectType === 'list'"> | |||
EmmyMay
force-pushed
the
2023.3.x-feature-select-list-view
branch
from
35933db
to
58cc602
Compare
|
LGTM |
EmmyMay
force-pushed
the
2023.3.x-feature-select-list-view
branch
from
58cc602
to
a8e32a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are implemented
TODO: Summary
Changes in the user interface:
TODO: Add screenshots, recordings or remove this section
Checklist when submitting a final (!draft) PR
Closes #1272