Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page builder save on close route to route back to the view page #1387

Merged
merged 1 commit into from Sep 7, 2023

Conversation

kelanik8
Copy link
Contributor

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@kelanik8 kelanik8 requested a review from Fajfa August 23, 2023 12:41
@kelanik8 kelanik8 self-assigned this Aug 23, 2023
@kelanik8 kelanik8 linked an issue Aug 23, 2023 that may be closed by this pull request
@Fajfa Fajfa force-pushed the 2023.3.x branch 2 times, most recently from 77f8765 to 7254628 Compare August 25, 2023 09:26
@kelanik8 kelanik8 force-pushed the 2023.3.x-bugfix-page-builder-navigation-state branch from a66dd81 to 9bf23f3 Compare August 29, 2023 14:14
client/web/compose/src/store/ui.js Outdated Show resolved Hide resolved
@katrinDY
Copy link
Contributor

I'm not redirected to the prev page after:

  • opening a record in a new tab -> page builder -> save and close
  • module list -> related pages -> click on edit record page/edit record list page -> save and close
  • module edit -> related pages -> click on edit record page/edit record list page of any page -> save and close
  • page tree -> page builder of any page -> save and close

@katrinDY
Copy link
Contributor

katrinDY commented Sep 4, 2023

One more case to resolve:

  • public pages -> Home -> edit page -> save and close -> I'm redirected to page tree instead of Home in public view

@katrinDY
Copy link
Contributor

katrinDY commented Sep 5, 2023

I found a strange edge case for modules and charts:

  • chart list -> select any chart type -> add chart name -> save -> click on back and you're redirected to create view -> click on back again and you're redirected to edit view of the new chart -> click on back again and you're redirected to edit view of the new chart => the cycle never ends
  • it's the same when creating a module

the issue isn't present when creating a ns, page or reccord

@kelanik8 kelanik8 force-pushed the 2023.3.x-bugfix-page-builder-navigation-state branch from 60613a9 to 04278e4 Compare September 7, 2023 07:34
@kelanik8 kelanik8 merged commit 04278e4 into 2023.3.x Sep 7, 2023
1 check passed
@kelanik8 kelanik8 deleted the 2023.3.x-bugfix-page-builder-navigation-state branch September 7, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page builder does not remember navigation state
3 participants