Fix issue with full-page navigation when show total is disabled #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
KinyaElGrande
force-pushed
the
2023.3.x-fix-fullpage-navigation
branch
from
3b4c76b
to
703904c
Compare
KinyaElGrande
force-pushed
the
2023.3.x-fix-fullpage-navigation
branch
from
703904c
to
52922eb
Compare
tjerman
approved these changes
Sep 5, 2023
tjerman
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
I'm not the biggest fan of cutting the mistake from pageNavigation -- I'd rather see the surrounding code change to exclude this edge case.
For me, it's ok as is but I'd suggest we add a little @todo to re-visit this function and clean it up properly -- it became a bit of a mess (my fault included 🙈)...
If it's tested and works as expected, it's mergable but do consider what I noted down above
KinyaElGrande
force-pushed
the
2023.3.x-fix-fullpage-navigation
branch
from
b6aed93
to
879add3
Compare
and resolve page count on the last page issue
KinyaElGrande
force-pushed
the
2023.3.x-fix-fullpage-navigation
branch
from
879add3
to
58e8653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1376
This PR resolves issues related to full-page navigation. It resolves cases when 'show total' is disabled, the last page has a count of 0 items and is never showed if the items on the last page are not equal to the limit, and an extra page consistently being returned in the
pageNavigationobject.