Compose sidebar navigation improvements #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fajfa
requested changes
Sep 26, 2023
| const block = new compose.PageBlockRecordList({ | ||
| blockIndex: 0, | ||
| options: { | ||
| moduleID: module.moduleID, |
There was a problem hiding this comment.
You dont need to reinit the whole block, it has a watcher on options, so just updating the moduleID should be enough
Also can you turn in into the regular watcher structure (the handler ()), also you need to check if module exists
client/web/compose/src/components/Namespaces/NamespaceSidebar.vue
Outdated
Show resolved
Hide resolved
client/web/compose/src/components/Namespaces/NamespaceSidebar.vue
Outdated
Show resolved
Hide resolved
Fajfa
requested changes
Sep 27, 2023
| created () { | ||
| const { meta = { ui: {} } } = this.module || {} | ||
|
|
||
| let fields = ((meta.ui || {}).admin || {}).fields || [] | ||
| fields = fields.length ? fields : this.module.fields | ||
|
|
||
| const { moduleID } = this.module |
There was a problem hiding this comment.
You shouldnt do it here, you do it 5 rows above
| @@ -347,6 +350,9 @@ export default { | |||
| }, | |||
|
|
|||
| adminRoutes () { | |||
| const routeName = this.$route.name | |||
| const pageName = routeName.endsWith('edit') ? 'admin.modules.edit' : 'admin.modules.record.list' | |||
There was a problem hiding this comment.
Wont this also trigger for admin.modules.record.edit?
kelanik8
force-pushed
the
2023.3.x-compose-sidebar-navigation-improvements
branch
from
2f2c2ec
to
1d22858
Compare
kelanik8
force-pushed
the
2023.3.x-compose-sidebar-navigation-improvements
branch
from
1d22858
to
703b8a1
Compare
kelanik8
force-pushed
the
2023.3.x-compose-sidebar-navigation-improvements
branch
from
703b8a1
to
8d9b4c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are implemented
TODO: Summary
Changes in the user interface:
TODO: Add screenshots, recordings or remove this section
Checklist when submitting a final (!draft) PR