Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more comprehensive .gitignore #13

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

himattm
Copy link

@himattm himattm commented Jun 20, 2020

πŸš€ Description

Update .gitignore to be more comprehensive. #12

πŸ“„ Motivation and Context

This is useful because upon first use of the template some files (like those in the .idea folder) were being included in git. The focus of this template seems to be to remove the need for fiddling with these types of files.

πŸ§ͺ How Has This Been Tested?

No files from the .gitignore are available via git.

πŸ“· Screenshots (if appropriate)

πŸ“¦ Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

βœ… Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Owner

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safe to merge as of now. Probably a bit too "big" and should be cleaned. On the other hand, it's probably better to keep the generated gitignore from gitignore.io and let users customize it.

@cortinico cortinico added the enhancement New feature or request label Jun 22, 2020
@cortinico cortinico merged commit 2db4740 into cortinico:master Jun 22, 2020
@cortinico
Copy link
Owner

Thanks for the contribution πŸ™

@himattm
Copy link
Author

himattm commented Jun 22, 2020

I think it's safe to merge as of now. Probably a bit too "big" and should be cleaned. On the other hand, it's probably better to keep the generated gitignore from gitignore.io and let users customize it.

I agree. I also debated on cleaning it up but if a curious user finds there way into the file, editing and generating from the site will provide a better diff on what is changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants