First working version #149
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update to .NET 6.0 * no longer using the old System.Text.Json NuGet package - now using the one in the .NET runtime libraries * property bags now created and modified through factory just like with the old Newtonsoft implementation * property bag implementation no longer public (propagation of serializer options means you get into all sorts of problems if people can create these without using the factory) * made specs more consistent with those in the Newtonsoft-based implementation to smooth the transition
Add queue-time build variable for forcing preview release
…gured in Azure DevOps instead - the yaml was just overriding it!)
I had mostly changed these to just Json, but I missed AddJsonDateTimeOffsetToIso8601AndUnixTimeConverter
AddJsonSerializerSettingsProvider -> AddJsonSerializerOptionsProvider The old name was the same as the one used by the Newtonsoft library. This is unhelpful because in some test scenarios we need to be able to call both (until such time as everything has moved over to System.Text.Json). And in any case, the thing it provides is called JsonSerializerOptions.
Also define new JsonElement-friendly methods to IJsonPropertyBagFactory. (Not yet implemented.)
Also refactored tests to fix these problems: * most of the steps were in one massive class * lots of things were going through the black hold that is the ScenarioContext * the use of the per-ScenarioContext DI container wasn't working because tests needed to modify the DI setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library has hitherto been in a bit of an experimental state. It was using an old NuGet package for
System.Text.Jsoninstead of the implementation built into the runtime. It didn't handle nullable reference types well. And it was quite inconsistent with the Newtonsoft implementation of the same abstractions.This PR addresses these issues, with the goal of making this library usable in practice for the first time.