Remove dependencies on the Skye library. #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the migration from Skye to GoogleMock, the code now compiles correctly, but the tests do not pass.
I had doubled the number of expected calls to now() by accident.
The travis checks use clang-format 3.9, I used 4.0.
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 99.07% 99.07% +<.01%
==========================================
Files 191 191
Lines 4219 4223 +4
==========================================
+ Hits 4180 4184 +4
Misses 39 39
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining a separate library for mocking was not worth it.