Skip to content

Commit

Permalink
Create PULL_REQUEST_TEMPLATE.md
Browse files Browse the repository at this point in the history
  • Loading branch information
coryhouse committed Feb 28, 2018
1 parent c36b88a commit 4f03a7d
Showing 1 changed file with 24 additions and 0 deletions.
24 changes: 24 additions & 0 deletions PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,24 @@
The code review checklist below is used for all pull requests.

1. Review the list before submitting your pull request.
2. Leave the list intact for the code reviewer's use.

Thanks! :)

## Code Review Checklist

- [ ] Latest code from master has been merged into the pull request branch
- [ ] Honors [the seven code virtues](https://pragprog.com/magazines/2011-08/how-virtuous-is-your-code)
- [ ] Working, as opposed to incomplete
- [ ] Unique, as opposed to duplicated
- [ ] Simple, as opposed to complicated
- [ ] Clear, as opposed to puzzling
- [ ] Easy, as opposed to difficult
- [ ] Developed, as opposed to primitive
- [ ] Brief, as opposed to chatty
- [ ] Code is camelCased
- [ ] No commented out code (if required, place // TODO above with explanation)
- [ ] No linting issues
- [ ] Automated tests exist and pass
- [ ] Build is successful (`npm run build`)
- [ ] Works in IE 11, Chrome, Firefox, and Edge

0 comments on commit 4f03a7d

Please sign in to comment.