Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load styles last for same beahviour as in dev mode #144

Merged
merged 1 commit into from May 19, 2016
Merged

Load styles last for same beahviour as in dev mode #144

merged 1 commit into from May 19, 2016

Conversation

rndstr
Copy link
Contributor

@rndstr rndstr commented May 17, 2016

In dev mode, local styles are loaded after other CSS included in <head>. For prod, the prepend() makes styles.css be parsed before the other CSS in<head>.

One fix is to use append() instead to make sure local styles are loaded last and in the same order as in development.

@coryhouse
Copy link
Owner

Great point. 👍 This makes sense to me, but can you please do me a favor and get latest to resolve a merge conflict and resubmit? Unfortunately someone else's separate PR changed the same line for a diff reason yesterday. :)

@rndstr
Copy link
Contributor Author

rndstr commented May 18, 2016

@coryhouse that was me :) rebased, thank you!

@coryhouse coryhouse added the bug label May 19, 2016
@coryhouse coryhouse merged commit a6e7248 into coryhouse:master May 19, 2016
@coryhouse
Copy link
Owner

Thanks @rndstr! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants