Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from React.PropTypes #418

Merged
merged 1 commit into from
Apr 10, 2017
Merged

migrate from React.PropTypes #418

merged 1 commit into from
Apr 10, 2017

Conversation

gabrielkunkel
Copy link
Contributor

This may be a bit early, but it has to be done some time...

With React 15.5.0, React.PropTypes are now extracted to a separate package.

They are still accessible via the main React object, but using them will log a deprecation warning to the console when in development mode.
3390e426-1c7c-11e7-8ee3-28720e13eb99

@coveralls
Copy link

coveralls commented Apr 10, 2017

Coverage Status

Coverage remained the same at 95.283% when pulling 7766211 on gabrielkunkel:master into cf69b17 on coryhouse:master.

@coryhouse coryhouse merged commit 042a9b9 into coryhouse:master Apr 10, 2017
@coryhouse
Copy link
Owner

Thanks! 👍

@mikedevita
Copy link
Contributor

mikedevita commented Apr 10, 2017

I'm curious, why is there another lib for prop-types? Is that now not included in react?

edit: looks like 16x is deprecating React.PropTypes and PropTypes in production builds, interesting... https://facebook.github.io/react/warnings/dont-call-proptypes.html

@coryhouse
Copy link
Owner

It was a change in 15.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants