Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatch handling and the Events API #5

Closed
coryodaniel opened this issue Dec 20, 2018 · 5 comments · Fixed by #156
Closed

dispatch handling and the Events API #5

coryodaniel opened this issue Dec 20, 2018 · 5 comments · Fixed by #156
Milestone

Comments

@coryodaniel
Copy link
Owner

coryodaniel commented Dec 20, 2018

While it is up the the individual controller to handle error cases, it would be nice to integrate the result of a controller dispatch with the kubernetes events API.

Return from add/modify/delete/reconcile would automatically create events:

  • :ok, {:ok, _} -> Normal
  • :error, {:error, _} -> Warning

There are a lot of fields for an Event. It would be nice to abstract as much of this away as possible, but allow for an explicit return value of something like {:ok, %K8s.Event{}} (doesnt exist) to override any logic bonny provides.

@coryodaniel
Copy link
Owner Author

coryodaniel commented Jan 4, 2019

Could be done independently of #22. May be nice to wait and use that interface. #22 is merged.

Create a module around events

References:

Regarding event occurrences count, consider a GenServer/Agent vs querying the k8s API and incrementing the count.

@coryodaniel
Copy link
Owner Author

Related: #5 #4 #2

This was referenced Feb 27, 2019
@coryodaniel coryodaniel added this to the 0.4 milestone Jun 25, 2019
@coryodaniel coryodaniel removed this from the 0.5 release milestone Oct 9, 2019
@coryodaniel coryodaniel added this to the 1.0 release milestone Feb 17, 2020
@mruoss mruoss mentioned this issue Sep 22, 2022
@sleipnir
Copy link
Contributor

Hi @mruoss Is it now possible to emit events to kubernetes API? Would they be available via kubectl get events or kubectl describe commands ?

@mruoss
Copy link
Collaborator

mruoss commented Sep 22, 2022

With the next version, yes. But although we have integration tests now, this requires some "production approval". Next version is probably going to be an RC...

@mruoss
Copy link
Collaborator

mruoss commented Sep 22, 2022

You can check guides/controllers.livemd (path to module is still hardcoded and needs to be changed, though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants