Implements telemetry for the Operator #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelgaspar
force-pushed
the
feature/operator-telemetry
branch
2 times, most recently
from
e6a0dfc
to
2c24d50
Compare
rafaelgaspar
commented
Nov 3, 2023
rafaelgaspar
force-pushed
the
feature/operator-telemetry
branch
from
2c24d50
to
bfcfd3b
Compare
|
Hey @rafaelgaspar Very nice, thanks. Could you please also add a new entry to the changelog? |
mruoss
reviewed
Nov 3, 2023
|
Since there is no tests for current telemetry implementation I did not add any new tests for this, that's why coveralls is failing, I could add some, but testing telemetry is kind of tricky, I would probably add telemetry_test. |
|
Yeah I'd consider testing telemetry a topic to tackle separately. You're very welcome to come up with something in a separate PR of course. |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all thanks this great project.
The Operator doesn't use the Reconciler's and Watcher's execution logic, it reimplements it directly from
get_raw_streamto work better with ControllerV2, but that means that we don't get telemetry data when using an Operator.This adds telemetry support for the Operator runs.