remove test and make dialyzer happy

coryodaniel · Mar 8, 2023 · 26c1d58 · 26c1d58
1 parent f7d672d
commit 26c1d58
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 30 deletions.
diff --git a/lib/k8s/conn/auth/azure.ex b/lib/k8s/conn/auth/azure.ex
@@ -2,7 +2,6 @@ defmodule K8s.Conn.Auth.Azure do
   @moduledoc """
   `auth-provider` for azure
   """
-  alias K8s.Conn.Error
   alias K8s.Conn.RequestOptions
 
   require Logger
@@ -54,7 +53,7 @@ defmodule K8s.Conn.Auth.Azure do
   end
 
   @spec refresh_token(String.t(), String.t(), String.t(), String.t()) :: String.t()
-  defp refresh_token(tenant, refresh_token, client_id, _apiserver_id) do
+  def refresh_token(tenant, refresh_token, client_id, _apiserver_id) do
     payload =
       URI.encode_query(%{
         "client_id" => client_id,
@@ -67,13 +66,13 @@ defmodule K8s.Conn.Auth.Azure do
         :post,
         URI.new!("https://login.microsoftonline.com/#{tenant}/oauth2/v2.0/token"),
         payload,
-        %{
-          "Content-Type" => "application/x-www-form-urlencoded"
-        },
+        [{
+          "Content-Type", "application/x-www-form-urlencoded"
+        }],
         ssl: []
       )
 
-    res["access_token"]
+    Map.get(res, "access_token")
   end
 
   defimpl RequestOptions, for: __MODULE__ do

diff --git a/test/k8s/conn/auth/azure_test.exs b/test/k8s/conn/auth/azure_test.exs
@@ -28,30 +28,6 @@ defmodule K8s.Conn.Auth.AzureTest do
                 token: "xxx"
               }} = Azure.create(auth, nil)
     end
-
-    @tag :skip
-    test "fails when token is expired" do
-      expired_unix_ts = DateTime.utc_now() |> DateTime.add(-10, :minute) |> DateTime.to_unix()
-
-      auth = %{
-        "auth-provider" => %{
-          "config" => %{
-            "access-token" => "xxx",
-            "apiserver-id" => "service_id",
-            "client-id" => "client_id",
-            "expires-on" => "#{expired_unix_ts}",
-            "refresh-token" => "yyy",
-            "tenant-id" => "tenant"
-          },
-          "name" => "azure"
-        }
-      }
-
-      assert {:error,
-              %K8s.Conn.Error{
-                message: "Azure token expired please refresh manually"
-              }} = Azure.create(auth, nil)
-    end
   end
 
   test "creates http request signing options" do