Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New implementations of Map and MapIndexed #117

Merged
merged 4 commits into from Oct 1, 2017

Conversation

cekdahl
Copy link
Contributor

@cekdahl cekdahl commented Oct 1, 2017

The goal for this pull request was to figure out how to deal with level specifications. The following two functions have been implemented:

  • Map
  • MapIndexed

Map existed before, but it did not accept level specifications.

@corywalker
Copy link
Owner

Thanks for this change! I like how this implementation seems easily reusable with other parts which may require level specs. I have one small request before merging. Instead of the last commit to fix the build error, could we have something like this:

https://pastebin.com/2MtMqLma

I'm trying to move towards using constructors for these instantiations. The constructors will save headaches if we ever need to add a field that defaults to a certain value.

@cekdahl
Copy link
Contributor Author

cekdahl commented Oct 1, 2017

Great, fixed it.

@corywalker
Copy link
Owner

Thanks. I'll merge once I see the tests pass.

@corywalker corywalker merged commit 1ae7825 into corywalker:master Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants