New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/batch script execution #150
Feature/batch script execution #150
Conversation
should expreduce/resources.go be gitignored?.. |
Hi @darvin , This was initially the case, but after releasing 0.1, I noticed that people were having issues with the go generate steps. This meant they could not easily "go run expreduce.go". In the end, cznic and I decided to include generated Go source in the repo. Context here: You're right that this will cause merge conflicts to happen often on resources.go, something I did not consider. Perhaps a simple fix would be to have a separate resources.go for each module, reducing the chance of this. Optionally an idea would not be to have this resources.go and somehow load the files directly. Not sure if there is a standard way to do this with Go packages. For now I'd recommend merging in changes from master and then regenerating resources.go. If it gets unmanageable we can implement one of the above solutions, or even gitignore resources.go. -Cory |
The changes in this PR look great though. Thanks for this change. I can merge after you address the conflict on resources.go. |
1f4bf55
to
2f48d8e
Compare
addressed |
offtopic, but have you considered using dep for dependency management/build system? I'm super new to golang, but it seems like something that would solve this problem (and much more) edit: maybe not, I just would imagine package manager would have "pre install" step where you can generate things |
I'm reading up on dep. It does seem to be used by some popular Go projects now. Not sure if it would help with the generated code issue, but it could help with managing versions of dependencies. |
Suggesting |
(I have no opinions on |
#147