-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entire code base reformat with black. Added github workflow for ci. #379
Conversation
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
- Coverage 70.47% 70.36% -0.12%
==========================================
Files 31 31
Lines 5528 5520 -8
==========================================
- Hits 3896 3884 -12
- Misses 1632 1636 +4
Continue to review full report at Codecov.
|
@ljchang This is ready to merge in. All tests are passing except for one which I think you might be able to fix. Any chance you can take a quick look: https://github.com/cosanlab/nltools/runs/2171188010?check_suite_focus=true#step:6:47 We're also having some weird platform issues around MAXINT on Windows, but fine on Ubuntu and macOS. As of now we don't support Python 3.9 as of yet because several of our dependencies are not Python 3.9 ready either. But 3.9 is still new enough that that's ok I think. Also our sphinx auto-gallery all builds without errors now and I can hook it up to deploy somewhere. Did you still want to use readthedocs or should I switch it to github pages? The total list of changes include:
|
I'll start looking through code, I would like to move documentation to github if possible, sick of debugging RTD. Is sphinx-gallery building on github actions? if so, that's awesome! |
ok @ljchang I fixed that failing test by giving our simulator classes a random seed and just pinning it for testing purposes. Also docs work great on gh-pages! https://cosanlab.github.io/nltools/ Did you want to setup up a custom domain? Will probably merge this PR in shortly. |
…code settings and extensions.
…. Add nojekyll after sphinx builds.
Also added vscode settings and recommended extensions