Skip to content

Commit

Permalink
Merge bitcoin#12622: net: Correct addrman logging
Browse files Browse the repository at this point in the history
b4db76c net: Correct addrman logging (Wladimir J. van der Laan)

Pull request description:

  These were introduced in bitcoin#9037.

  Found by @theuni (bitcoin#9037 (review)).

Tree-SHA512: 9b5153da8a8e5d4ddf9513a5c453f9609cffd4df2924fd48c7b36c1b1055748c7077d4fc0e70be62ca36af87df7f621a744bb374a234baba271ce4982a240825
  • Loading branch information
laanwj authored and gades committed Jul 1, 2021
1 parent 61062bd commit 2cdf496
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/addrman.cpp
Expand Up @@ -254,7 +254,7 @@ void CAddrMan::Good_(const CService& addr, bool test_before_evict, int64_t nTime

// Will moving this address into tried evict another entry?
if (test_before_evict && (vvTried[tried_bucket][tried_bucket_pos] != -1)) {
if (fLogIPs) LogPrint(BCLog::ADDRMAN, "addrman", "Collision inserting element into tried table, moving %s to m_tried_collisions=%d\n", addr.ToString(), m_tried_collisions.size());
if (fLogIPs) LogPrint(BCLog::ADDRMAN, "Collision inserting element into tried table, moving %s to m_tried_collisions=%d\n", addr.ToString(), m_tried_collisions.size());
if (m_tried_collisions.size() < ADDRMAN_SET_TRIED_COLLISION_SIZE) {
m_tried_collisions.insert(nId);
}
Expand Down Expand Up @@ -597,7 +597,7 @@ void CAddrMan::ResolveCollisions_()

// Give address at least 60 seconds to successfully connect
if (GetAdjustedTime() - info_old.nLastTry > 60) {
LogPrint(BCLog::ADDRMAN, "addrman", "Swapping %s for %s in tried table\n", info_new.ToString(), info_old.ToString());
LogPrint(BCLog::ADDRMAN, "Swapping %s for %s in tried table\n", info_new.ToString(), info_old.ToString());

// Replaces an existing address already in the tried table with the new address
Good_(info_new, false, GetAdjustedTime());
Expand Down

0 comments on commit 2cdf496

Please sign in to comment.