Skip to content

Commit

Permalink
qt: Make sure splash screen is freed on AppInitMain fail
Browse files Browse the repository at this point in the history
The `splashFinished` event was never sent if AppInitMain fails,
causing the splash screen to stick around, causing problems
later.

This bug has existed for a while but is now trigging potential crashed
because the splash screen subscribes to wallet events.

Meant to fix bitcoin#12372.

Signed-off-by: Wladimir J. van der Laan <laanwj@gmail.com>
  • Loading branch information
laanwj committed Feb 7, 2018
1 parent 1462bde commit f5a4c3d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/qt/bitcoin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,7 @@ void BitcoinApplication::initializeResult(bool success)
QTimer::singleShot(100, paymentServer, SLOT(uiReady()));
#endif
} else {
Q_EMIT splashFinished(window);
quit(); // Exit main loop
}
}
Expand Down

0 comments on commit f5a4c3d

Please sign in to comment.