Refactor register #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shink
commented
Aug 2, 2024
| @@ -1,33 +1,7 @@ | |||
| #pragma GCC visibility push(default) | |||
There was a problem hiding this comment.
这里的符号设置暂时先删掉了，与 CUDAGuardImpl.cpp 保持一致
shink
commented
Aug 2, 2024
|
|
||
| #include "csrc/core/Register.h" | ||
|
|
||
| C10_REGISTER_PRIVATEUSE1_BACKEND(npu); |
There was a problem hiding this comment.
这里只调用了一下注册 privateuse1 name 的接口，是否需要单独放这个文件里？
hippocookie
reviewed
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.