Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add missing headers, remove compiler warnings #86

Merged
merged 13 commits into from Apr 22, 2020
Merged

refactor: add missing headers, remove compiler warnings #86

merged 13 commits into from Apr 22, 2020

Conversation

gocarlos
Copy link
Member

@gocarlos gocarlos commented Apr 20, 2020 •
edited

what:

  • add missing headers e.g. stdbool for c99 bool
  • remove unneeded variables

why:

  • IDEs need this for correct auto-completion and its a good practice
  • reduce compiler warnings

@coveralls
Copy link

coveralls commented Apr 20, 2020 •
edited

Coverage Status

Coverage increased (+0.009%) to 91.105% when pulling c3539a8 on gocarlos:refactor--add-missing-headers into 0ac6481 on cose-wg:master.

@gocarlos gocarlos changed the title refactor: add missing headers refactor: add missing headers, remove compiler warnings Apr 20, 2020
@gocarlos
Copy link
Member Author

@jimsch please review

jimsch
jimsch requested changes Apr 20, 2020
View reviewed changes
include/cose/cose.h Show resolved Hide resolved
src/Recipient.c Show resolved Hide resolved
src/SignerInfo.c Outdated Show resolved Hide resolved
test/context.c Show resolved Hide resolved
test/encrypt.c Show resolved Hide resolved
test/test.c
@@ -334,7 +334,6 @@ bool SetAttributes(HCOSE hHandle, const cn_cbor * pAttributes, int which, int ms
const cn_cbor * pValue;
int keyNew;
cn_cbor * pValueNew;
bool f = false;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than getting rid of this variable. Return it and combine the different items together. Not sure why I removed the assert. It is possible that doing this change might cause test failures. If so let me know.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimsch ok, it seems like the assert does not work

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimsch could you have a look in this?

@gocarlos gocarlos requested a review from jimsch April 21, 2020 19:18
jimsch
jimsch reviewed Apr 22, 2020
View reviewed changes
test/test.c Show resolved Hide resolved
@gocarlos gocarlos requested a review from jimsch April 22, 2020 08:15
@gocarlos
Copy link
Member Author

ready

@jimsch jimsch merged commit 2a14519 into cose-wg:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimsch jimsch Awaiting requested review from jimsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gocarlos @coveralls @jimsch