Fix library to work with API changes after 17 Nov 2015 #204
Conversation
florianbeer
commented
Mar 8, 2016
florianbeer
commented
- Add new permission scopes
- Require access token for all endpoints
- Remove deprecated endpoints
- Fix parameters for endpoints
- Fix pagination
Fix error IN getUserMedia API
|
Please approve this request |
|
I agree, I was about to make a PR to add new permission scopes and I saw this. |
Bring back "xRateLimitRemaining" data
| } | ||
|
|
||
| return $this->_makeCall($function, $auth, array('cursor' => $obj->pagination->next_cursor, 'count' => $limit)); | ||
| return $this->_makeCall($function, array('next_max_id' => $obj->pagination->next_max_id, 'count' => $count)); |
There was a problem hiding this comment.
The pagination call is made with a parameter named "next_max_id". It seems that it should be named "max_id". For example, see the parameters for the "/users/self/media/recent/" endpoint. Am I missing something?
There was a problem hiding this comment.
Pagination seems to work for me, but maybe I didn't use that endpoint yet.
Did you test it out? What is the error message you are getting back from the Twitter API?
If this is indeed an error, please make a pull request with the changed parameter name.
Thank you.
There was a problem hiding this comment.
I don't get any error from Instagram, but each pagination call returns the same batch of results. Changing "next_max_id" to "max_id" allowed me to get the next batch of items in the paginated list.
Readme states that `getUserFollows()` and `getUserFollower()` accepts an `$id` and `$limit`, however these were never used. Also, nothing was ever returned.
Fixes getUserFollows and getUserFollower
|
|
…rties are used in _makeOAuthCall() and _makeCall().
Added Proxy functionaly.
