Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommendation: rename _print to _latex #24

Closed
drmowinckels opened this issue Sep 6, 2022 · 1 comment · Fixed by #26
Closed

recommendation: rename _print to _latex #24

drmowinckels opened this issue Sep 6, 2022 · 1 comment · Fixed by #26

Comments

@drmowinckels
Copy link

I'd recommend renaming the _print functions to _latex. This will make it more clear that the functions create latex output.
Also, it creates a clear distinction from R print methods, that other developers and more advanced users might be familiar with, which is quite different.

as part of openjournals/joss-reviews#4740

@cosimameyer
Copy link
Owner

Thanks so much for this suggestion - that's excellent! I didn't think about it this way (we first envisioned the overview_print function to become a much broader function but it remained an overview_latex function as it is now and you are right - this name serves its purpose much better 😊). We discussed it internally and are very happy to go forward with your suggestion in PR #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants