RT #96016: "\n" in a string not escaped properly

[ghost]

Hi Cosimo, here is the patch I mentioned. Some of the changes in the test file are due to me running perltidy with the perltidyrc file in the root directory, but I also tidied up one of the msgstr arguments as all those escapes where bugging me :D ... oh and added a test for inline "\n" :)

[cosimo]

Hi Jeff, good work, thanks!

I'm uncertain about all the quoting business. You cleaned that up a bit, so it's better, but I'm wondering if a round-trip test with inline \n will break (msgid with inline \n -> dump to file -> reload from file -> check if msgid is the same).

I'm keen on trying to add such a test.

[ghost]

I added a round trip test, I think the pull request auto added the new
commit ... let me know if I'm wrong on that.

Also I added a MANIFEST.SKIP since it makes running make manifest easier.

Cheers, Jeff.

On Wed, May 28, 2014 at 4:51 PM, Cosimo Streppone
notifications@github.comwrote:

Hi Jeff, good work, thanks!

I'm uncertain about all the quoting business. You cleaned that up a bit,
so it's better, but I'm wondering if a round-trip test with inline \n will
break (msgid with inline \n -> dump to file -> reload from file -> check if
msgid is the same).

I'm keen on trying to add such a test.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-44371428
.

The fundamental cause of the trouble is that in the modern world the stupid
are cocksure while the intelligent are full of doubt.
— Bertrand Russell, ‘The Triumph of Stupidity’, 1933/05/10, Mortals and
Others: Bertrand Russells’ American Essays, 1931–1935.

[cosimo]

Great, thanks!