Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the sign on mu_star_shell. #79

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Conversation

jsitarek
Copy link
Collaborator

It was always assuming that the shell is "behind" the blob, i.e. that mu>1, however if the blob is inside the shell, some parts of it will have mu<0

…l is "behind" the blob, i.e. that mu>1, however if the blob is inside the shell, some parts of it will have mu<0
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 17, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.26%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 27.20 ⭐ 30.60 ⭐ 3.40 👎
Working memory 8.58 🙂 8.67 🙂 0.09 👎
Quality 81.76% 80.50% -1.26% 👎
Other metrics Before After Change
Lines 41 47 6
Changed files Quality Before Quality After Quality Change
agnpy/utils/geometry.py 81.76% ⭐ 80.50% ⭐ -1.26% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
agnpy/utils/geometry.py cos_psi 0 ⭐ 47 ⭐ 10 😞 76.97% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #79 (b70c68f) into master (489f1cc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   93.97%   93.98%   +0.01%     
==========================================
  Files          30       30              
  Lines        1727     1730       +3     
==========================================
+ Hits         1623     1626       +3     
  Misses        104      104              
Flag Coverage Δ
unittests 93.98% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agnpy/utils/geometry.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 489f1cc...b70c68f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants