Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed misleading comment #82

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

jsitarek
Copy link
Collaborator

the value used was correct, but the explanation was wrong

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 23, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.37 ⭐ 1.37 ⭐ 0.00
Method Length 63.71 🙂 63.71 🙂 0.00
Working memory 11.62 😞 11.62 😞 0.00
Quality 66.52% 🙂 66.52% 🙂 0.00%
Other metrics Before After Change
Lines 537 537 0
Changed files Quality Before Quality After Quality Change
agnpy/absorption/absorption.py 66.52% 🙂 66.52% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
agnpy/absorption/absorption.py Absorption.evaluate_tau_ss_disk 0 ⭐ 233 ⛔ 18 ⛔ 45.35% 😞 Try splitting into smaller methods. Extract out complex expressions
agnpy/absorption/absorption.py Absorption.evaluate_tau_blr 0 ⭐ 147 😞 15 😞 55.37% 🙂 Try splitting into smaller methods. Extract out complex expressions
agnpy/absorption/absorption.py Absorption.evaluate_tau_dt_mu_s 0 ⭐ 140 😞 15 😞 56.14% 🙂 Try splitting into smaller methods. Extract out complex expressions
agnpy/absorption/absorption.py Absorption.evaluate_tau_dt 0 ⭐ 131 😞 14 😞 58.43% 🙂 Try splitting into smaller methods. Extract out complex expressions
agnpy/absorption/absorption.py Absorption.evaluate_tau_ps_behind_blob_mu_s 0 ⭐ 133 😞 11 😞 62.92% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #82 (91e5be0) into master (15d39d9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files          31       31           
  Lines        1896     1896           
=======================================
  Hits         1769     1769           
  Misses        127      127           
Flag Coverage Δ
unittests 93.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agnpy/absorption/absorption.py 94.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d39d9...91e5be0. Read the comment docs.

@jsitarek jsitarek linked an issue Feb 23, 2021 that may be closed by this pull request
@cosimoNigro cosimoNigro merged commit 91b5679 into cosimoNigro:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

absorption (DT) for gamma rays moving with an angle to the jet axis
2 participants