-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added numerical check between agnpy and Finke 2016 for absorption on BLR and DT #89
Conversation
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 94.35% 94.36% +0.01%
==========================================
Files 30 30
Lines 2054 2059 +5
==========================================
+ Hits 1938 1943 +5
Misses 116 116
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 1.57%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
So far we were just producing plots for the crosschecks against the Finke 2016 reference for the case of the gamma-gamma absorption on the BLR and DT.
I added the
check_deviation
function at the end of the functions checking these absorptions numerically against the reference.These are the automatic plots produced now by the
TestAbsorption
classfor the BLR
![tau_blr_Ly_alpha_comprison_r_1e-1_R_Ly_alpha_figure_14_finke_2016](https://user-images.githubusercontent.com/26409711/115860941-7d279c00-a432-11eb-9b73-ed93bb2179fd.png)
![tau_blr_Ly_alpha_comprison_r_1e0 5_R_Ly_alpha_figure_14_finke_2016](https://user-images.githubusercontent.com/26409711/115860945-7e58c900-a432-11eb-8f5c-8b66933fc9c4.png)
![tau_blr_Ly_alpha_comprison_r_1e1_R_Ly_alpha_figure_14_finke_2016](https://user-images.githubusercontent.com/26409711/115860943-7dc03280-a432-11eb-8d22-2caaca9f3c9f.png)
![tau_blr_point_source_comparison](https://user-images.githubusercontent.com/26409711/115862900-0213b500-a435-11eb-8aa8-896344ac31a6.png)
and for the DT
![tau_dt_comprison_r_1e-1_R_Ly_alpha_figure_14_finke_2016](https://user-images.githubusercontent.com/26409711/115861383-04750f80-a433-11eb-91c1-1ea4e7a2f35c.png)
![tau_dt_comprison_r_1e0_R_Ly_alpha_figure_14_finke_2016](https://user-images.githubusercontent.com/26409711/115861390-050da600-a433-11eb-8925-01fa775f3723.png)
![tau_dt_comprison_r_1e1_R_Ly_alpha_figure_14_finke_2016](https://user-images.githubusercontent.com/26409711/115861387-050da600-a433-11eb-920c-9d6ccb348944.png)
![tau_dt_comprison_r_1e2_R_Ly_alpha_figure_14_finke_2016](https://user-images.githubusercontent.com/26409711/115861386-04750f80-a433-11eb-8f61-8f711bc99a0f.png)
![tau_dt_point_source_comparison](https://user-images.githubusercontent.com/26409711/115862932-08099600-a435-11eb-8ab7-9b9bbc8e8847.png)
Keeping in mind that, thanks to @jsitarek work, we are also checking against the point-source approximation (for the misaligned case) I think we can close both issues #65 and #66.
I think for the BLR and DT the absorption is under control.