Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use prettier for all supported file types (except markdown) #193

Merged
merged 2 commits into from
Jun 15, 2019
Merged

use prettier for all supported file types (except markdown) #193

merged 2 commits into from
Jun 15, 2019

Conversation

chrisblossom
Copy link
Contributor

@chrisblossom chrisblossom commented Jun 13, 2019 •
edited
Loading

removes remark dependency as well

Uses remark-preset-davidtheclark to format markdown.

@chrisblossom chrisblossom mentioned this pull request Jun 13, 2019
Closed
@codecov-io
Copy link

codecov-io commented Jun 13, 2019 •
edited
Loading

Codecov Report

Merging #193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #193   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         210    210           
=====================================
  Hits          210    210

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6003890...d66be5a. Read the comment docs.

davidtheclark
davidtheclark reviewed Jun 14, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@chrisblossom
Copy link
Contributor Author

I copied how you are using your remark-preset-davidtheclark cli. Not sure if I should include the format option?

davidtheclark
davidtheclark reviewed Jun 15, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
@chrisblossom chrisblossom changed the title use prettier for all supported file types use prettier for all supported file types (except markdown) Jun 15, 2019
davidtheclark
davidtheclark approved these changes Jun 15, 2019
View reviewed changes
Copy link
Collaborator

@davidtheclark davidtheclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@davidtheclark davidtheclark merged commit 6da6871 into cosmiconfig:master Jun 15, 2019
@chrisblossom chrisblossom deleted the use-prettier-for-md branch June 15, 2019 23:16
davidtheclark pushed a commit that referenced this pull request Nov 2, 2019
@chrisblossom @davidtheclark
use prettier for all supported file types (except markdown) (#193)
4b41f27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtheclark davidtheclark davidtheclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisblossom @codecov-io @davidtheclark