Breaking: remove cosmiconfig.loaders and add named export defaultLoaders. #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 231 228 -3
Branches 51 51
=====================================
- Hits 231 228 -3
Continue to review full report at Codecov.
|
chrisblossom
force-pushed
the
loaders-to-named-export
branch
from
6ed7df8
to
9608f77
Compare
davidtheclark
approved these changes
Jul 28, 2019
| @@ -303,17 +303,19 @@ Default: See below. | |||
|
|
|||
| An object that maps extensions to the loader functions responsible for loading and parsing files with those extensions. | |||
|
|
|||
| Cosmiconfig exposes its default loaders for `.js`, `.json`, and `.yaml` as `cosmiconfig.loadJs`, `cosmiconfig.loadJson`, and `cosmiconfig.loadYaml`, respectively. | |||
| Cosmiconfig exposes its default loaders as a named export `defaultLoaders` for `.js`, `.json`, and `.yaml` as `defaultLoaders.loadJs`, `defaultLoaders.loadJson`, and `defaultLoaders.loadYaml`, respectively. | |||
There was a problem hiding this comment.
Suggested change
| Cosmiconfig exposes its default loaders as a named export `defaultLoaders` for `.js`, `.json`, and `.yaml` as `defaultLoaders.loadJs`, `defaultLoaders.loadJson`, and `defaultLoaders.loadYaml`, respectively. | |
| Cosmiconfig exposes its default loaders on a named export `defaultLoaders`. The loaders for `.js`, `.json`, and `.yaml` are `defaultLoaders.loadJs`, `defaultLoaders.loadJson`, and `defaultLoaders.loadYaml`, respectively. |
There was a problem hiding this comment.
Did you want me to put another PR in with the requested changes?
There was a problem hiding this comment.
Oh, oops. I'll take care of it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because named exports are used it makes sense to directly export the default loaders instead of attaching it to the actual
cosmiconfigexport.