Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

⬆ Bump ServiceStack.Text from 6.4.0 to 6.5.0 #22

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"csharpier": {
"version": "0.19.1",
"version": "0.21.0",
"commands": [
"dotnet-csharpier"
]
Expand Down
9 changes: 8 additions & 1 deletion .devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"name": "CosminSanda.Finance",
"dockerComposeFile": "docker-compose.yml",
"service": "dev",
"workspaceFolder": "/workspace",
"extensions": [
"formulahendry.dotnet-test-explorer",
"formulahendry.dotnet",
Expand All @@ -10,6 +13,10 @@
"obrejla.netbeans-light-theme",
"editorconfig.editorconfig",
"streetsidesoftware.code-spell-checker",
"ms-dotnettools.dotnet-interactive-vscode"
"ms-dotnettools.dotnet-interactive-vscode",
"sonarsource.sonarlint-vscode",
"cschleiden.vscode-github-actions",
"mutantdino.resourcemonitor",
"devescalus.git-commit-no-verify-action-button"
]
}
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
fail_fast: false
repos:
- repo: https://github.com/AleksaC/hadolint-py
rev: v1.19.0
hooks:
- id: hadolint
args: [--ignore, DL3004]
46 changes: 46 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
{
"files.exclude": {
"**/.git": true,
"**/.idea": true,
"**/.DS_Store": true,
"**/Thumbs.db": true
},
"files.associations": {
},
"cSpell.words": [
"buildsystems",
"Cava",
"cavathor",
"Codespace",
"cppcheck",
"cpplint",
"cpptools",
"cschleiden",
"devcontainer",
"devescalus",
"elagil",
"gersemi",
"hadolint",
"hiredis",
"hykin",
"instdir",
"IRAW",
"jeppeandersen",
"linelength",
"lukka",
"mutantdino",
"proto3",
"protoc",
"REDISDESTINATION",
"resourcemonitor",
"sonarlint",
"sonarsource",
"subdir",
"surajbarkale",
"uncrustify",
"vcpkg",
"VCPKG"
],
"workbench.tree.indent": 24,
"git.postCommitCommand": "push"
}
6 changes: 3 additions & 3 deletions Finance/.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
<metadata>
<id>CosminSanda.Finance</id>
<version>1.1.5</version>
<version>1.1.6</version>
<title>Yahoo Earnings Calendar</title>
<authors>Cosmin Catalin Sanda</authors>
<owners>cosmincatalin</owners>
Expand All @@ -16,8 +16,8 @@
<dependencies>
<group>
<dependency id="CsvHelper" version="30.0.1" />
<dependency id="Newtonsoft.Json" version="13.0.1" />
<dependency id="ServiceStack.Text" version="6.4.0" />
<dependency id="Newtonsoft.Json" version="13.0.2" />
<dependency id="ServiceStack.Text" version="6.5.0" />
</group>
<group targetFramework="net6.0" />
</dependencies>
Expand Down
8 changes: 4 additions & 4 deletions Finance/Finance.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@
<PropertyGroup>
<RootNamespace>CosminSanda.Finance</RootNamespace>
<NuspecFile>.nuspec</NuspecFile>
<LangVersion>10</LangVersion>
<LangVersion>11</LangVersion>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="CsvHelper" Version="30.0.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="ServiceStack.Text" Version="6.4.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
<PackageReference Include="ServiceStack.Text" Version="6.5.0" />
</ItemGroup>

</Project>
3 changes: 1 addition & 2 deletions Finance/JsonConverters/EarningsReleaseConverter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ JsonSerializerOptions options

string ticker = null;
string company = null;
// ReSharper disable once TooWideLocalVariableScope
DateOnly earningsDate;
var earningsDate = new DateOnly();
string earningsDateType = null;
double? epsEstimate = null;
double? epsActual = null;
Expand Down
4 changes: 2 additions & 2 deletions Tests/Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
<IsPackable>false</IsPackable>
<LangVersion>10</LangVersion>
<LangVersion>11</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
6 changes: 3 additions & 3 deletions docfx_project/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ This package simplifies the process of retrieving data from Yahoo Finance.
Currently, it can fetch information about earnings calls and about daily quotes.

This package can be used, typically, to analyze the price action around historical earnings calls for the purpose
of establishing strategies for future earnings releases a.k.a "Playing the Earnings".
of establishing strategies for future earnings releases a.k.a **"Playing the Earnings"**.

The package acts as a proxy to Yahoo Finance and is essentially a web scraper.
While in previous versions, caching was built in, it has been removed.
That means all methods make requests directly to Yahoo Finance and it is your responsibility to cache the data so as to avoid redundant requests.
The reason for disabling the cache has to do with the lack of guarantees regarding the provided data which can lead to inconsistencies for less popular instruments.

Methods are made static to make it easier to use from interactive environments.
* Methods are made static to make it easier to use from interactive environments.
That is also the reason why there aren't a lot of options for Dependencies Injection of, for example, logging.
To further simplify the use of methods in the package, arguments are passed using basic types like `string` and `int32`.
* To further simplify the use of methods in the package, arguments are passed using basic types like `string` and `int32`.
1 change: 0 additions & 1 deletion docfx_project/tutorials/intro.md

This file was deleted.

2 changes: 0 additions & 2 deletions docfx_project/tutorials/toc.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
- name: Introduction
href: intro.md
- name: dotnet-interactive
href: dotnet-interactive.md
9 changes: 9 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
version: "3.9"
services:
dev:
build:
context: .
dockerfile: docker/dev.Dockerfile
volumes:
- .:/workspace
command: sleep infinity
11 changes: 11 additions & 0 deletions docker/dev.Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
FROM mcr.microsoft.com/devcontainers/dotnet:7.0

RUN sudo apt update
RUN sudo apt remove -y cmake
RUN sudo apt install -y \
python3-pip \
uncrustify \
nodejs
RUN pip install \
pre-commit==2.20.0
RUN git config --global --add safe.directory /workspace