Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reporting Order-ID in Kafka as string, not int #24

Merged
merged 4 commits into from
Apr 18, 2017
Merged

reporting Order-ID in Kafka as string, not int #24

merged 4 commits into from
Apr 18, 2017

Conversation

cosminrentea
Copy link
Owner

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 67.341% when pulling 3049d21 on feature/reporting-kafka-string-orderid into 39b3981 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 67.498% when pulling 3049d21 on feature/reporting-kafka-string-orderid into 39b3981 on master.

marian-craciunescu
marian-craciunescu reviewed Apr 18, 2017
View reviewed changes
server/sms/nexmo_sms_sender.go Outdated
@@ -94,7 +94,7 @@ type NexmoMessageReport struct {
}

type ReportPayload struct {
OrderId int `json:"order_id"`
OrderId string `json:"order_id,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OrderID maybe ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed this and MessageId as suggested

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 67.533% when pulling d26755a on feature/reporting-kafka-string-orderid into 39b3981 on master.

@cosminrentea cosminrentea merged commit 5c976e2 into master Apr 18, 2017
@cosminrentea cosminrentea deleted the feature/reporting-kafka-string-orderid branch April 18, 2017 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogh bogh bogh approved these changes

@marian-craciunescu marian-craciunescu marian-craciunescu approved these changes

@zeisss zeisss Awaiting requested review from zeisss

@stefanscheidt stefanscheidt Awaiting requested review from stefanscheidt

@fabzo fabzo Awaiting requested review from fabzo

@everesio everesio Awaiting requested review from everesio

@robinnepomukmai robinnepomukmai Awaiting requested review from robinnepomukmai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@cosminrentea @coveralls @bogh @marian-craciunescu