disable/enable SMS and other modules, at runtime #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
April 19, 2017 16:15
…/stop logic exposed using endpoint for all modules, with their name as URL parameters
… becomes idempotent
… names / packages
…start, only on restart
…on Stop; tests are passing
added 7 commits
April 24, 2017 11:48
…bscribing on Stop; adding and fixing tests
server/connector/connector.go
Outdated
| c.cancel() | ||
| c.cancel=nil |
server/service/service.go
Outdated
| le.WithError(err).Error("Error while stopping module") | ||
| } | ||
| w.Write([]byte(fmt.Sprintf("%s was stopped.\n", modulePackage))) | ||
| } |
There was a problem hiding this comment.
what response is returned if an error is encountered.
There was a problem hiding this comment.
added proper error-handling
marian-craciunescu
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.