Feature/pn 310 ttl for messages #7
Conversation
… feature/pn-310-ttl-for-messages
bogh
requested review from
zeisss,
stefanscheidt,
cosminrentea,
marian-craciunescu and
robinnepomukmai
… feature/pn-310-ttl-for-messages
| ID: id, | ||
| Path: Path(meta[0]), | ||
| UserID: meta[2], | ||
| ApplicationID: meta[3], | ||
| Expires: expiresTime, |
There was a problem hiding this comment.
This field should be ExpirationTime not Expires.
… feature/pn-310-ttl-for-messages
| // consider the message as processed and log the action | ||
| // | ||
| // RFC3339 format | ||
| Expires *time.Time |
There was a problem hiding this comment.
Why are you using RFC3339 for Expires, but a unix timestamp for Time below?
There was a problem hiding this comment.
We require the message to also contain timezone information.
There was a problem hiding this comment.
Sorry for me asking, but why are you requiring the timezone information? Wouldn't it suffice to know the exact time the message expires? Which is given by a unix timestamp (since it is in UTC).
There was a problem hiding this comment.
You might be correct, but we had some issues with timezone information checking on other project and would like for the producer to be able to fully control without any uncertainty.
No description provided.