Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements for webhooks #737

Merged
merged 2 commits into from
Jun 3, 2023
Merged

improvements for webhooks #737

merged 2 commits into from
Jun 3, 2023

Conversation

jlandowner
Copy link
Member

Close #726
Close #735

@jlandowner jlandowner added bug Something isn't working controller-manager Controller Manager go Pull requests that update Go code labels Jun 3, 2023
@jlandowner jlandowner requested a review from oruharo June 3, 2023 08:02
@jlandowner jlandowner changed the title use the same dryrun reconcile logic in Template webhook and Instance … improvements for webhooks Jun 3, 2023
@oruharo oruharo merged commit e522cbf into cosmo-workspace:main Jun 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oruharo oruharo Awaiting requested review from oruharo

Assignees
No one assigned
Labels
bug Something isn't working controller-manager Controller Manager go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
2 participants
@jlandowner @oruharo