Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes inserted text is surrounded with %% #190

Closed
annda opened this issue Aug 17, 2023 · 0 comments · Fixed by #197
Closed

Sometimes inserted text is surrounded with %% #190

annda opened this issue Aug 17, 2023 · 0 comments · Fixed by #197

Comments

@annda
Copy link
Contributor

annda commented Aug 17, 2023

This seems to happen when nested spans are found in the pasted text.

Some relevant code to investigate:

Possibly the inserted text is rendered as nowiki text and the user removes that (outer) formatting. The inner %% are preserved.
annda added a commit that referenced this issue Dec 12, 2023
@annda
Improve handling of unformatted text
eb6d709 
- do not assume any pasted text that includes a span is unformatted (nowiki)
- visually highlight unformatted text in editor
- disable adding format marks (like bold) inside unformatted text
- add 'unformatted' to text style dropdown

Fixes #190

Addresses but does not yet resolve #101
annda added a commit that referenced this issue Dec 12, 2023
@annda
Improve handling of unformatted text
6fef7e1 
- do not assume any pasted text that includes a span is unformatted (nowiki)
- visually highlight unformatted text in editor
- disable adding format marks (like bold) inside unformatted text
- add 'unformatted' to text style dropdown

Fixes #190

Addresses but does not yet resolve #101
@annda annda mentioned this issue Dec 12, 2023
Merged
annda added a commit that referenced this issue Dec 13, 2023
@annda
Improve handling of unformatted text
e3835d8 
- do not assume any pasted text that includes a span is unformatted (nowiki)
- visually highlight unformatted text in editor
- disable adding format marks (like bold) inside unformatted text
- add 'unformatted' to text style dropdown

Fixes #190

Addresses but does not yet resolve #101
annda added a commit that referenced this issue Dec 13, 2023
@annda
Improve handling of unformatted text (#197)
4b4f793 
- do not assume any pasted text that includes a span is unformatted (nowiki)
- visually highlight unformatted text in editor
- disable adding format marks (like bold) inside unformatted text
- add 'unformatted' to text style dropdown

Fixes #190

Addresses but does not yet resolve #101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve handling of unformatted text cosmocode/dokuwiki-plugin-prosemirror
1 participant
@annda