Dropdown #40
Merged
Dropdown #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives much more control to the individual menu item and is needed for dropdowns. MenuItems may now get a render method instead of a dom method. Also, they may have an update() method to do custom updating.
Still needs some work
They will have to be reworked when the markup is somewhat stable
This always runs the is-active check on update A dropdown is now active if any of its items are active more consistent markup and thus simpler styling
The will be many more marks than just these 3, so grouping them into a dropdown makes sense
splitbrain
reviewed
Jun 14, 2018
| } | ||
| } | ||
|
|
||
| exports.Dropdown = Dropdown; |
There was a problem hiding this comment.
JSDoc is a thing, we should use it ;-)
|
Looks good, I'd like to see more doc blocks for the JavaScript though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToDo:
Optional: