Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Canvas Resizing, View Fitting, and Memory Management #105

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

Stukova
Copy link
Contributor

@Stukova Stukova commented Mar 11, 2024

  • Canvas Resizing: Previously, centering of the view was lost when resizing the canvas. Now, the centering is saved during resizing.

  • Paddings when Fitting the View: When fitting the view, the paddings are now taken into account as a percentage of the view size.

  • Prevent Maximum call stack size exceeded: Calculating the minimum and maximum values using Math.min and Math.max with spread operators can lead to Maximum call stack size exceeded error, especially when dealing with large arrays. To address this issue, the d3-array extend method is used instead, which is more memory-efficient and provides the same functionality.

@Stukova Stukova added the bug Something isn't working label Mar 11, 2024
@Stukova Stukova requested a review from rokotyan March 11, 2024 08:13
@rokotyan rokotyan merged commit 2eba967 into main Mar 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants