Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must modify the way to generate js codes from proto files #4

Open
taiki1frsh opened this issue Oct 19, 2022 · 2 comments
Open

Must modify the way to generate js codes from proto files #4

taiki1frsh opened this issue Oct 19, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@taiki1frsh
Copy link

taiki1frsh commented Oct 19, 2022

As the structure of the proto management of wasmd repository has changed, the current way to generate the js files from proto files don't work.
We have to modify (or possibly radically change the client structure).

cc: @mkXultra @Senna46

Specifically, gen-proto.sh, gen-openapi.sh requires raw dependent proto files (third-party protos) to generate ts files.
But, since the way to manage the dependent files changed, there's no longer third-party proto folder in wasmd.

So, have to change the way to manage dependent files in process to generate ts proto files in the both scripts.

@taiki1frsh taiki1frsh added the bug Something isn't working label Oct 19, 2022
@Senna46
Copy link
Contributor

Senna46 commented Oct 25, 2022

Seems to have been in 0.27.0 (doc version)

https://docs.cosmwasm.com/docs/1.0/getting-started/installation

https://github.com/CosmWasm/wasmd/tree/v0.27.0

When use this, the error occured

Error: Unexpected token in option: .get
    at onoption (/home/user/.npm/_npx/08926cdeed955aef/node_modules/protocol-buffers-schema/parse.js:347:15)
    at onrpc (/home/user/.npm/_npx/08926cdeed955aef/node_modules/protocol-buffers-schema/parse.js:517:17)
    at onservice (/home/user/.npm/_npx/08926cdeed955aef/node_modules/protocol-buffers-schema/parse.js:449:30)
    at Function.parse (/home/user/.npm/_npx/08926cdeed955aef/node_modules/protocol-buffers-schema/parse.js:596:30)
    at Object.parseSchema (/home/user/.npm/_npx/08926cdeed955aef/node_modules/pbjs/index.js:6:27)
    at Object.<anonymous> (/home/user/.npm/_npx/08926cdeed955aef/node_modules/pbjs/cli.js:21:24)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
/home/user/.npm/_npx/08926cdeed955aef/node_modules/protocol-buffers-schema/parse.js:347
        throw new Error('Unexpected token in option: ' + tokens[0])
        ^

@Senna46
Copy link
Contributor

Senna46 commented Oct 25, 2022

In https://github.com/cosmos-client/ununifi-ts, there are same errors.
@taiki1frsy @mkXultra Do you know anything about its error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants