Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto config and the way to generate files from them #224

Closed
taiki1frsh opened this issue Aug 9, 2022 · 4 comments
Closed

proto config and the way to generate files from them #224

taiki1frsh opened this issue Aug 9, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@taiki1frsh
Copy link
Collaborator

taiki1frsh commented Aug 9, 2022

Currently, we place third party proto files directly in our repository without having buf configs under proto folder to configure the rules to generate files from proto files.
Also we use old versin of buf and protoc to be compatible with the old way to generate them.
So the goal is to remove buf protoc way and construct new way to generate go files from proto files with buf generate command.
References:
https://github.com/osmosis-labs/osmosis/blob/ab06a4f8e938f930c4cc9bab5606f453a88c9ac6/Makefile#L168
https://github.com/osmosis-labs/osmosis/blob/ab06a4f8e938f930c4cc9bab5606f453a88c9ac6/scripts/protocgen.sh
https://github.com/osmosis-labs/osmosis/blob/ab06a4f8e938f930c4cc9bab5606f453a88c9ac6/scripts/generate-proto.sh

@taiki1frsh
Copy link
Collaborator Author

When this issue will be addresses, please do these below issues at the same time.
cosmos-client/cosmwasm-ts#4
cosmos-client/ununifi-ts#14

They're related issues and require drastic point for both of them.
So, after solving those issues all, submit PRs for each repo.

@hikaruNagamine hikaruNagamine self-assigned this Jan 5, 2023
@hikaruNagamine hikaruNagamine linked a pull request Feb 6, 2023 that will close this issue
@hikaruNagamine
Copy link
Contributor

@hikaruNagamine
Copy link
Contributor

@taiki1frsh
I changed to use the buf generate command and addressed the issue of third-party proto files not being in the repository and not being referenced.
We would appreciate your confirmation that you are aware of the perspective of the fixes.🙇‍♂️

@taiki1frsh
Copy link
Collaborator Author

@hikaruNagamine
yes, i'm aware of those.

  • we should use latest version of buf tools
  • we shouldn't have third-party proto files in the repository directory

these two are the stuff to be achieved for this issue, I think.

@mkXultra mkXultra added the enhancement New feature or request label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants