Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unbonding periods to chains so relayers can set trust_periods #29

Closed
sunnya97 opened this issue Oct 14, 2021 · 4 comments · Fixed by #1164
Closed

Add unbonding periods to chains so relayers can set trust_periods #29

sunnya97 opened this issue Oct 14, 2021 · 4 comments · Fixed by #1164

Comments

@sunnya97
Copy link
Member

No description provided.

@nooomski
Copy link
Contributor

I like this, but how do we make sure this is updated after a governance proposal changes the param? Responsibility of chain.json maintainers?

@JeremyParish69
Copy link
Collaborator

I like this, but how do we make sure this is updated after a governance proposal changes the param? Responsibility of chain.json maintainers?

Is this something the lens tool could verify? and then have a script to submit a change if needed?

@JeremyParish69
Copy link
Collaborator

JeremyParish69 commented Dec 6, 2022

What should be the unit of duration? It probably goes technically always goes by number of blocks, but we'll probably also want an estimated time duration. And in what units should that time be? I suppose day is common enough, but we may end up having to change to hour, and seconds would be best unit with very high precision. Should it be a number with assumed unit? Or allow for a regex'd string? or some kind of datetime format?

I might propose:

"staking": {
  "staking_tokens": [
    {
      "denom": "uosmo",
      "lock_duration": {
        "blocks": 12345678,
        "time": "14 days"
      }
    }
  ]
}

why did I put the duration inside the staking token object? same reason as why the staking tokens is an array and not a single denom: in case different tokens have different locking durations.
E.g., ION staking is not for the chain, but might be nice to be able to record that here.

Alternatively, we could go with more assumptions (like staking always describing chain security--which might be best), then we could also do:

"staking": {
  "staking_tokens": [
    {
      "denom": "uosmo"
    }
  ],
  "lock_duration": {
    "blocks": 12345678,
    "time": "14 days"
  }
}

@JeremyParish69
Copy link
Collaborator

Should we change the entire staking section to look like this?
osmosisd q staking params

bond_denom: uosmo
historical_entries: 10000
max_entries: 7
max_validators: 118
min_commission_rate: "0.050000000000000000"
min_self_delegation: "0"
unbonding_time: 1209600s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants