Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create toBech32 and fromBech32 in @cosmjs/encoding #1053

Closed
4 tasks done
webmaster128 opened this issue Feb 21, 2022 · 0 comments · Fixed by #1058
Closed
4 tasks done

Create toBech32 and fromBech32 in @cosmjs/encoding #1053

webmaster128 opened this issue Feb 21, 2022 · 0 comments · Fixed by #1058
Assignees
@msteiner96
Projects
CosmJS
Milestone
0.28.0

Comments

@webmaster128
Copy link
Member

webmaster128 commented Feb 21, 2022 •
edited by msteiner96

Using classes for namespacing as we do in Bech32.encode/Bech32.decode is bad practice in JavaScript. Both should become free functions.

  • Create toBech32 and fromBech32
  • Implement Bech32.encode and Bech32.decode using the functions above for backwards compatibility
  • Deprecare Bech32.encode, Bech32.decode and Bech32
  • Add CHANGELOG entry
@webmaster128 webmaster128 added this to the 0.28.0 milestone Feb 21, 2022
@webmaster128 webmaster128 added this to To do in CosmJS via automation Feb 21, 2022
@webmaster128 webmaster128 moved this from To do to Next in CosmJS Feb 21, 2022
@msteiner96 msteiner96 moved this from Next to In progress in CosmJS Feb 22, 2022
@msteiner96 msteiner96 self-assigned this Feb 22, 2022
@msteiner96 msteiner96 mentioned this issue Feb 22, 2022
Merged
@msteiner96 msteiner96 moved this from In progress to Awaiting Review in CosmJS Feb 22, 2022
CosmJS automation moved this from Awaiting Review to Done Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msteiner96 msteiner96

Labels
None yet
Projects
CosmJS
Done
Milestone
0.28.0
Development

Successfully merging a pull request may close this issue.

Create toBech32 and fromBech32 in @cosmjs/encoding cosmos/cosmjs
2 participants
@webmaster128 @msteiner96