Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Validator signing infos with empty addresses #1436

Closed
livthomas opened this issue Jun 19, 2023 · 2 comments
Closed

Bug: Validator signing infos with empty addresses #1436

livthomas opened this issue Jun 19, 2023 · 2 comments

Comments

@livthomas
Copy link
Contributor

It looks like there is some problem with validator signing infos. It is not possible to get signing infos for all bonded validators. Some records are simply missing.

When I try to get all signing infos using query client with slashing extension, I can see that some records contain an empty string in the address field. This might point at some serialization issue.

I can only reproduce this problem on Cosmos Hub. It does not affect any other Cosmos chain I have tried.

Steps to Reproduce

  1. Get all signing infos via RPC
  2. Get all bonded validators via RPC
  3. Try to match validators to their signing infos
  4. See how many validators do not have any signing infos
  5. See that there are some signing infos with empty addresses

Reproducer

You can find a simple reproducer script here:
https://github.com/RBFLabs/bug-reproducers/tree/main/cosmos/cosmjs/empty-signing-info-addresses

@livthomas livthomas changed the title Validator signing infos with empty addresses Bug: Validator signing infos with empty addresses Jun 22, 2023
@webmaster128
Copy link
Member

Thank you for bringing this up. To be honest, I never worked with signingInfos and don't know the expected output. I think we need someone from the Cosmos SDK or Comet teams to check this out.

@livthomas
Copy link
Contributor Author

I think we can close this issue since it probably doesn't have anything to do with cosmjs library as it can be easily reproduced by hitting the REST API directly. Moreover, it looks like it is not even an issue with Cosmos SDK but something specific to Cosmos Hub because I'm not able to reproduce it anywhere else.

@livthomas livthomas closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants