Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AppContext and ChainInfo state #155

Closed
abefernan opened this issue Jun 26, 2023 · 1 comment · Fixed by #157
Closed

Refactor AppContext and ChainInfo state #155

abefernan opened this issue Jun 26, 2023 · 1 comment · Fixed by #157
Assignees
@abefernan

Comments

@abefernan
Copy link
Contributor

abefernan commented Jun 26, 2023 •
edited
Loading

The files in context/ and components/chainSelect/ChainSelect.tsx should be refactored.

/multi should be the /chainId of the network instead, so that a link to a different chain than the one stored in localStorage does not break the app.
@abefernan abefernan self-assigned this Jun 26, 2023
@abefernan abefernan mentioned this issue Jul 3, 2023
Merged
@abefernan
Copy link
Contributor Author

abefernan commented Jul 3, 2023 •
edited
Loading

In #157 /multi was replaced by /registryName instead of /chainId, since we use it to query the network from the chain-registry, so it should match the network folder name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abefernan abefernan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement new ChainsProvider cosmos/cosmos-multisig-ui
1 participant
@abefernan