Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct bit length constant for sdk.Dec #11128

Closed
4 tasks
hallazzang opened this issue Feb 7, 2022 · 0 comments · Fixed by #11332
Closed
4 tasks

Use correct bit length constant for sdk.Dec #11128

hallazzang opened this issue Feb 7, 2022 · 0 comments · Fixed by #11332
Labels
C:Types T:Bug

Comments

@hallazzang
Copy link
Contributor

hallazzang commented Feb 7, 2022 •
edited

Summary of Bug

sdk.Dec is using maxBitLen internally in some places, but it should use maxDecBitLen as intended.

Version

c00cedb

Steps to Reproduce

This will return an error, which it should not return(The value is the maximum value of sdk.Dec):

sdk.NewDecFromStr("133499189745056880149688856635597007162669032647290798121690100488888732861290.034376435130433535")

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:Types T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): use correct bit length constant for sdk.Dec
2 participants
@hallazzang @alexanderbez