LCD Rest API returning unreadable bonded amount

[7768]

To reproduce:

1. gaiacli advanced rest-server
2. Go to localhost:1317/stake/validators or ~$ curl http://localhost:1317/stake/validators | jq
3. You see something silly:

The root cause seems to be from MarshalJSON of PoolShares. See https://github.com/cosmos/cosmos-sdk/blob/develop/x/stake/client/rest/query.go#L172

[ValarDragon]

Seems to be fixed on develop:

[{"owner":"cosmosvaladdr1af7e7gn4ksk29xaaj00wwyq93fh90u6k3rvyx3",
"pub_key":"cosmosvalpub1zcjduc3qlxd89kg8x6wn95q0u2ps7j0nu4uva6ue69qk75gsrczfhlv5qvrsj9j6zx",
"revoked":false,"pool_shares":{"status":2,"amount":"100"},"delegator_shares":"100",
"description":{"moniker":"foo","identity":"","website":"","details":""},
"bond_height":0,"bond_intra_tx_counter":0,"proposer_reward_pool":null,
"commission":"0","commission_max":"0","commission_change_rate":"0",
"commission_change_today":"0","prev_bonded_shares":"0"}]

(This was on a clean install), did you do anything else to get that strange output? If not, then this may have been fixed by the unbonding PR.

[7768]

I just tested on develop:

$ gaiacli version
0.20.0-dev-473ac4a3

And I can reproduce the same problem when connected to gaia-6002.
For instance:

A lot of validators are partially slashed, which is why you see the ugly fractions. If the numbers are whole integers, they look fine.

See this related ticket: #1354

[ValarDragon]

Oh I see. Didn't notice the slash there.

[rigelrozanski]

Yeah this should probably be resolved by using human readable output for rationals

[rigelrozanski]

(but not with the JSON output, I reckon we want all those digits in this situation)

[rigelrozanski]

This issue will be addressed by switching to decimal in #1807