grpc service reflection.

[tac0turtle]

Summary

Currently we have two service.reflection apis.

This is somewhat confusing and could be consolidated to one.

Proposal

merge both reflection apis into one and add file descriptors, mark it as v1.

[tac0turtle]

the most relevant thing I would like to keep/add in the api is:

// ConfigurationDescriptor contains metadata information on the sdk.Config
message ConfigurationDescriptor {
  // bech32_account_address_prefix is the account address prefix
  string bech32_account_address_prefix = 1;
  // bech32_validator_address_prefix is the validator address prefix
  string bech32_validator_address_prefix = 2;
  // bech32_consensus_address_prefix is the consensus key address prefix
  string bech32_consensus_address_prefix = 3;
  // minimum_gas_price is the gas set by the node operator
  string minimum_gas_price = 4;
}

not sure which other parts people may find useful so would be good to understand the addition

[aaronc]

So my gripe with putting that together in a reflection API is that in my mind those all belong to different parts of the system and that separation of concerns leads to better maintainability. We should be clear about what the scope of a reflection service is. In my mind the original intent was just describing the protobuf codec - basically the FileDescriptorSet and information in it.

All those address prefixes have been bunched together into a global, but that's one of the deepest pieces of tech debts to get rid of.

In my mind, bech32 account prefixes belong with x/auth and the validator and consensus prefixes belong with x/staking. x/auth already provides an address codec and a grpc query. I think we should add similar things to staking.

Putting them in reflection if that's mainly proto codecs seems like not the right place.

[tac0turtle]

reflection is the name of the current api, but it doesn't have to be. Bez named it node, but it could be something else.

We can add it to auth as well since it wont be a global anymore. Im open to that, then maybe we drop the current reflection apis.

[tac0turtle]

I can move this to staking and auth configuration endpoints and get rid of the current apis if that is agreed on. Filedescriptor covers most all the end points there