Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/gov)!: Use KVStoreService, context.Context, return errors, better iterators #15988

Merged
merged 20 commits into from
May 5, 2023

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Apr 28, 2023

Description

  • Use KVStoreService instead of StoreKey
  • Use context.Context instead of sdk.Context
  • Return errors instead of panic in Keeper methods
  • Improve iterators to use ErrStopIterating instead of a found bool

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@@ -327,8 +330,7 @@
// updates.
func (am AppModule) EndBlock(ctx context.Context) error {
c := sdk.UnwrapSDKContext(ctx)
EndBlocker(c, am.keeper)
return nil
return EndBlocker(c, am.keeper)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
@github-actions github-actions bot added the C:Rosetta Issues and PR related to Rosetta label May 2, 2023
@facundomedica facundomedica marked this pull request as ready for review May 2, 2023 18:40
@facundomedica facundomedica requested a review from a team as a code owner May 2, 2023 18:40
@github-prbot github-prbot requested review from a team, tac0turtle and julienrbrt and removed request for a team May 2, 2023 18:40
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. (v0.48 will be very breaking 😅)

x/gov/types/errors.go Outdated Show resolved Hide resolved
Co-authored-by: Julien Robert <julien@rbrt.fr>
@tac0turtle tac0turtle added this pull request to the merge queue May 5, 2023
Merged via the queue into main with commit 4f00acf May 5, 2023
51 checks passed
@tac0turtle tac0turtle deleted the facu/gov-kvstoresvc branch May 5, 2023 10:16
rllola pushed a commit to Zondax/cosmos-sdk that referenced this pull request May 11, 2023
… better iterators (cosmos#15988)

Co-authored-by: Julien Robert <julien@rbrt.fr>
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
… better iterators (cosmos#15988)

Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Rosetta Issues and PR related to Rosetta C:Simulations C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants