refactor(x/slashing)!: use kvStoreService, context.Context and return errors #16246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…cosmos-sdk into facu/slashing-kvstoresvc
…/slashing-kvstoresvc
| k.HandleValidatorSignature(ctx, voteInfo.Validator.Address, voteInfo.Validator.Power, comet.BlockIDFlag(voteInfo.BlockIdFlag)) | ||
| sdkCtx := sdk.UnwrapSDKContext(ctx) | ||
| for _, voteInfo := range sdkCtx.VoteInfos() { | ||
| err := k.HandleValidatorSignature(ctx, voteInfo.Validator.Address, voteInfo.Validator.Power, comet.BlockIDFlag(voteInfo.BlockIdFlag)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
…/slashing-kvstoresvc
github-prbot
requested review from
a team,
JeancarloBarrios and
likhita-809
and removed request for
a team
19 tasks
julienrbrt
reviewed
May 30, 2023
julienrbrt
changed the title
tac0turtle
reviewed
May 30, 2023
| iter, err := store.Iterator(types.ValidatorSigningInfoKeyPrefix, storetypes.PrefixEndBytes(types.ValidatorSigningInfoKeyPrefix)) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer iter.Close() |
There was a problem hiding this comment.
should this go above the if err so its added to the stack or the assumption is the error would mean that iterator is not opened
There was a problem hiding this comment.
The assumption is that the error means the iterator is not open, there's also a static check for that
tac0turtle
reviewed
May 30, 2023
tac0turtle
reviewed
May 30, 2023
julienrbrt
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… errors
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change